Bug when adding user to a group as a manager - Print Topic

I get this message whenever I attempt to add a user to a group or make a user the manager of a group.

Quoted Text

Sorry, but an error occurred. If you are unsure about how to solve this error you can contact the system administrator.

You either did not select any usernames, or the names you entered were invalid.

How are you adding them?

with the groups manager

i want non-admins to be able to add users to their group (example: /a-groups/group-6/)

You'll have to excuse my ignorance, never used this feature. I created a test group and member but see no way of adding him to the group this way :-/

OK, I found it and from what I can see, the group needs to be set to Accepting Members, the Member needs to apply to be added and they will show in a list. The manager can then add or deny their request.

I am trying to add them to the managers part of the group

It works for me on my test board, if you want me to take a look the pm Admin login info.

The funny thing is the command works and it adds them to the managers list, but it still throws up the

Quoted Text

You either did not select any usernames, or the names you entered were invalid.

Error

I think I've located it. I tried to change it to work but I still get the error.

Filename: Members.pl

Original Code (where I believe the error is coming from):

Code

	foreach(split(',',$type)) {
		GetMemberID($_);

		if($memberid{$_}{'sn'} eq '') { $_ = FindUsername($_); GetMemberID($_); }

		if($memberid{$_}{'sn'} eq '' || ($username ne $_ && $manager{$_} && !$members{'Administrator',$username})) { next; }
		$chosen{$_} = 1;
		$addgroup .= "$_,";
	}
	$addgroup =~ s/,\Z//g;
	if($addgroup eq '' || ($FORM{'manage'} && !$members{'Administrator',$username})) { error($memtext[214]); }

I figured since my main admin group is not called "Administrator", I would just replace it with "High Admin" (which is the name of the admins on the forum).

Here is my change:

Code

	foreach(split(',',$type)) {
		GetMemberID($_);

		if($memberid{$_}{'sn'} eq '') { $_ = FindUsername($_); GetMemberID($_); }

		if($memberid{$_}{'sn'} eq '' || ($username ne $_ && $manager{$_} && !$members{'High Admin',$username})) { next; }
		$chosen{$_} = 1;
		$addgroup .= "$_,";
	}
	$addgroup =~ s/,\Z//g;
	if($addgroup eq '' || ($FORM{'manage'} && !$members{'High Admin',$username})) { error($memtext[214]); }

I still get the error. That is the only place $memtext[214] (the error message) is in the Members.pl file. Does anyone have any suggestions?

Print Topic - Archive